Add more checks to the --mount flag parsing logic#5925
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Jan 21, 2025
Merged
Add more checks to the --mount flag parsing logic#5925openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
* Make volumes.GetBindMount(), volumes.GetCacheMount(), and volumes.GetTmpfsMount() return errors when flags which expect arguments are given empty arguments, when flags which don't expect arguments are given arguments, and when the "relabel" flag, which expects an argument, doesn't get one. * Make volumes.GetCacheMount() not treat the "U" flag as affecting bind propagation. * Drop the special-case error message when a caller attempts to use "src" or "source" options in volumes.GetTmpfsMount(), which would already be covered by the general-purpose "unrecognized option" default. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
mount-flags-parsing
branch
from
9324657 to
9b9c161
Compare
Member
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
volumes.GetBindMount(),volumes.GetCacheMount(), andvolumes.GetTmpfsMount()return errors when flags which expect arguments are given empty arguments, when flags which don't expect arguments are given arguments, and when the "relabel" flag, which expects an argument, doesn't get one.volumes.GetCacheMount()not treat the "U" flag as affecting bind propagation.volumes.GetTmpfsMount(), which would already be covered by the general-purpose "unrecognized option" default.How to verify it
New unit tests!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?