Detect breaking API changes in proto files#12776
Merged
mikebrow merged 1 commit intocontainerd:mainfrom Jan 13, 2026
Merged
Conversation
dosubot
bot
added
the
github_actions
Member
Yep, pretty sure this is on purpose. Mind demoing the job on your fork? |
Signed-off-by: Maksym Pavlenko <[email protected]>
Member
Author
|
@samuelkarp yes, see here: mxpv#40 |
Member
Author
|
It even supports annotations: |
samuelkarp
approved these changes
Jan 13, 2026
github-project-automation
bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
github-project-automation
bot
moved this from Review In Progress
to Done
in Pull Request Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #12762
This adds a CI job to detect breaking changes in proto files (using buf's breaking subcommand).
There is also an option to skip this check if there is
breaking-api-changelabel attached to the PR.ccing @containerd/committers to be aware of this label ^^
Also looks like Github won't run new jobs from PRs until it gets merged first.