Migrate from protobuild to buf#12762
Merged
fuweid merged 10 commits intocontainerd:mainfrom Jan 9, 2026
Merged
Conversation
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
dmcgowan
approved these changes
Jan 9, 2026
fuweid
approved these changes
Jan 9, 2026
Member
fuweid
left a comment
There was a problem hiding this comment.
LGTM
- protoc: (unknown) is not bug. bufbuild/buf#3913
- We should have follow-up to cleanup warning from buf
+ protos
(cd api && buf dep update)
(cd api && PATH="/home/fuweid/go/src/github.com/containerd/containerd//bin:$PATH" buf generate)
WARN plugin "protoc-gen-go-fieldpath" does not support required features.
Feature "proto3 optional" is required by 1 file(s):
services/images/v1/images.proto
This was referenced Jan 12, 2026
kzys
added a commit
to containerd/cgroups
that referenced
this pull request
Feb 27, 2026
Like containerd did recently, we can migrate from protobuild to buf. containerd/containerd#12762 Co-Authored-By: Claude Opus 4.6 <[email protected]>
kzys
added a commit
to containerd/cgroups
that referenced
this pull request
Feb 27, 2026
Like containerd did recently, we can migrate from protobuild to buf. containerd/containerd#12762 Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
added a commit
to containerd/cgroups
that referenced
this pull request
Feb 27, 2026
Like containerd did recently, we can migrate from protobuild to buf. containerd/containerd#12762 Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
added a commit
to containerd/cgroups
that referenced
this pull request
Mar 5, 2026
Like containerd did recently, we can migrate from protobuild to buf. containerd/containerd#12762 Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
added a commit
to containerd/cgroups
that referenced
this pull request
Mar 5, 2026
Like containerd did recently, we can migrate from protobuild to buf. containerd/containerd#12762 Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
added a commit
to containerd/cgroups
that referenced
this pull request
Mar 5, 2026
Like containerd did recently, we can migrate from protobuild to buf. containerd/containerd#12762 Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
added a commit
to containerd/cgroups
that referenced
this pull request
Mar 5, 2026
Like containerd did recently, we can migrate from protobuild to buf. containerd/containerd#12762 Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
added a commit
to containerd/cgroups
that referenced
this pull request
Mar 5, 2026
Like containerd did recently, we can migrate from protobuild to buf. containerd/containerd#12762 Signed-off-by: Kazuyoshi Kato <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates from
Protobuild(which we all love and use for quite some time) tobufto manage our proto files.Immediate benefits:
protocdependency. Mush simpler CI setup.buf.yamlandbuf.lock, so same output is expected everywhere. Only thebufbinary need to be installed on the system to get things going.containerdto be inGOPATH(not strictly buf’s feature, but implemented in this PR)There are also some longer term nice-to-have features that we could benefit from, which we don't have in protobuild:
I was able to generate exactly the same code with buf as it was before.
The only annoying thing is
// protoc (unknown)which seems to be expected when buf is not using external protoc binary (which we don't):
Made a few follow up changes based on feedback:
bufsupports natively), so workarounds in theMakefileno longer necessary.bufconfiguration files underapi/directory