test: add missing tests for get_filenames_in_commit with git_reference#1883
Draft
toroleapinc wants to merge 1 commit intocommitizen-tools:masterfrom
Draft
Conversation
Add test coverage for get_filenames_in_commit() when called with an explicit git_reference parameter. Previously only the error case and the integration test (no git_reference) existed. New tests: - test_get_filenames_in_commit: success case without git_reference - test_get_filenames_in_commit_with_git_reference: success case with explicit reference, verifying the correct git command is called - test_get_filenames_in_commit_error_with_git_reference: error case with explicit reference Closes commitizen-tools#1860 Signed-off-by: edvatar <[email protected]>
toroleapinc
requested review from
Lee-W,
noirbizarre and
woile
as code owners
|
Collaborator
|
Please answer the questions in PR description template and please fix the pipeline failure |
bearomorphism
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
Collaborator
|
And we already assigned #1860 to another contributor. You should comment on the issue and ask if you can take the issue first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add test coverage for
get_filenames_in_commit()when called with an explicitgit_referenceparameter. Previously only the error case (no reference) and an integration test existed.New tests
test_get_filenames_in_commit: success case without git_referencetest_get_filenames_in_commit_with_git_reference: success case with explicit reference, verifying the correct git command is constructedtest_get_filenames_in_commit_error_with_git_reference: error case with explicit referenceCloses #1860