Skip to content

Example private data from backend#10

Merged
davidcheung merged 14 commits intomainfrom
example-private-data-from-backend
Nov 19, 2020
Merged

Example private data from backend#10
davidcheung merged 14 commits intomainfrom
example-private-data-from-backend

Conversation

@davidcheung
Copy link
Copy Markdown
Contributor

@davidcheung davidcheung commented Nov 16, 2020

  • templates out auth routes
  • leverage new templating feature to move fileupload to be optionally templated
  • move status to app/
  • adds a new route expecting oathkeeper to pass in headers for authenticated users x-user-id and x-user-email

@davidcheung davidcheung force-pushed the example-private-data-from-backend branch 2 times, most recently from 30c565f to 5877d15 Compare November 16, 2020 21:47
@davidcheung davidcheung force-pushed the example-private-data-from-backend branch from 5877d15 to 127e3bd Compare November 16, 2020 21:48
@davidcheung davidcheung requested a review from a team November 16, 2020 21:48
@bmonkman
Copy link
Copy Markdown
Contributor

Are you going to add the k8s changes in this PR as well or separately?

@davidcheung
Copy link
Copy Markdown
Contributor Author

Are you going to add the k8s changes in this PR as well or separately?

@bmonkman the k8s changes as in the oathkeeper rules? do i only need to create the rules resources?

@bmonkman
Copy link
Copy Markdown
Contributor

Are you going to add the k8s changes in this PR as well or separately?

@bmonkman the k8s changes as in the oathkeeper rules? do i only need to create the rules resources?

Yes, creating the rules and also conditionally creating the ingress.

@@ -0,0 +1,31 @@
apiVersion: oathkeeper.ory.sh/v1alpha1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a doc to each of these so people know what they are for? Especially the backend endpoints which are the ones a developer is more likely to need to change in the future.
Actually, I wonder if kratos-public and kratos-form-data should be set up in the kubernetes terraform instead, since they aren't really specific to the app.. And maybe we even want a different subdomain for it? like auth.<% index .Params productionHostRoot %>?
Might be worth doing some testing though, because it depends on how they have set up the session cookie. If it's tied to the subdomain we'll have to do it this way otherwise it won't be able to read the cookie.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats true, they dont really have much to do with the backend itself 🤔

as in Oathkeeper will listen from 2 ingresses? then proxy to the same place after?
yeah the cookie/redirection stuff may cause issues

@davidcheung davidcheung merged commit dce0973 into main Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants