Merged
Conversation
davidcheung
force-pushed
the
example-private-data-from-backend
branch
2 times, most recently
from
9df3378 to
3f85c9b
Compare
davidcheung
force-pushed
the
example-private-data-from-backend
branch
from
3f85c9b to
6b98f47
Compare
bmonkman
reviewed
Nov 24, 2020
| @@ -0,0 +1,37 @@ | |||
| package auth | |||
Contributor
There was a problem hiding this comment.
Mind moving this from the root into internal?
bmonkman
reviewed
Nov 24, 2020
templates/auth/auth.go
Outdated
| "net/http" | ||
| ) | ||
|
|
||
| func getUserInfoFromHeaders(r *http.Request) (error, string, string) { |
Contributor
There was a problem hiding this comment.
How about returning a user info struct rather than strings?
Contributor
There was a problem hiding this comment.
Oh this is just private. Maybe think about how to expose this so other routes can check it too?
bmonkman
approved these changes
Nov 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should be equivalent to commitdev/zero-backend-node#10 but for the go-backend