Skip to content

zero-268: set s3_hosting module cf_signed_downloads #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GrooveStomp merged 1 commit into from
Sep 11, 2020
Merged

zero-268: set s3_hosting module cf_signed_downloads #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions templates/terraform/environments/prod/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ module "prod" {
"<% index .Params `productionFrontendSubdomain` %><% index .Params `productionHostRoot` %>",
]
domain_name = "<% index .Params `productionHostRoot` %>"
cf_signed_downloads = <% if eq (index .Params `fileUploads`) "yes" %>true<% else %>false<% end %>

# DB configuration
database = "<% index .Params `database` %>"
Expand Down
1 change: 1 addition & 0 deletions templates/terraform/environments/stage/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ module "stage" {
"<% index .Params `stagingFrontendSubdomain` %><% index .Params `stagingHostRoot` %>",
]
domain_name = "<% index .Params `stagingHostRoot` %>"
cf_signed_downloads = <% if eq (index .Params `fileUploads`) "yes" %>true<% else %>false<% end %>

# This will save some money as there a cost associated to each NAT gateway, but if the AZ with the gateway
# goes down, nothing in the private subnets will be able to reach the internet. Not recommended for production.
Expand Down
1 change: 1 addition & 0 deletions templates/terraform/modules/environment/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ module "s3_hosting" {
# We need to wait for certificate validation to complete before using the certs
depends_on = [module.assets_domains.certificate_validations]

cf_signed_downloads = var.cf_signed_downloads
buckets = var.s3_hosting_buckets
project = var.project
environment = var.environment
Expand Down
6 changes: 6 additions & 0 deletions templates/terraform/modules/environment/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,3 +137,9 @@ variable "sendgrid_api_key_secret_name" {
description = "AWS secret manager's secret name storing the sendgrid api key"
type = string
}

variable "cf_signed_downloads" {
type = bool
description = "Enable Cloudfront signed URLs"
default = false
}