Merged
Conversation
bmonkman
reviewed
Aug 31, 2020
| # application_policy_list = [ | ||
| # { | ||
| # service_account = "app1" | ||
| # namespace = "piggycloud-me" |
Contributor
There was a problem hiding this comment.
Maybe just "my-app" instead of "piggycloud"? And just one map in the list to make it shorter?
bmonkman
reviewed
Aug 31, 2020
| # Create policies | ||
| resource "aws_iam_policy" "irsa" { | ||
| count = length(var.application_policy_list) | ||
| name_prefix = var.project |
Contributor
There was a problem hiding this comment.
Should probably be project + environment in case someone has two environments in a single aws account.
bmonkman
reviewed
Aug 31, 2020
|
|
||
| # define policy documents for applications | ||
| # sample policies | ||
| data "aws_iam_policy_document" "resource_access_app1" { |
Contributor
There was a problem hiding this comment.
In all these files can you just make it a single example? The second one doesn't really provide any benefit.
bmonkman
reviewed
Aug 31, 2020
| # Application policy list | ||
| application_policy_list = [ | ||
| { | ||
| service_account = "app1" |
Contributor
There was a problem hiding this comment.
How about we change this service account name to "backend-service" or something and then also change the zero-deployable-backend project to use this service account?
bmonkman
approved these changes
Aug 31, 2020
bmonkman
added a commit
that referenced
this pull request
Oct 10, 2020
* initial commits for IRSA support * fixes with irsa * refresh naming * refresh naming * Updated README for IRSA * fixes per review * Added more detailed documentation * adjusted per review Co-authored-by: Bill Monkman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please help review @bmonkman