Conversation
…plying. ES cluster is internal so this has to be done via a container in k8s.
davidcheung
reviewed
Aug 27, 2020
davidcheung
reviewed
Aug 27, 2020
Co-authored-by: David Cheung <[email protected]>
Co-authored-by: David Cheung <[email protected]>
…lt instance types for ES clusters
davidcheung
approved these changes
Aug 28, 2020
Contributor
Author
|
Just running through one more full |
Contributor
|
nice, reminder to squash the commits since our default github behavior doesn't do that |
Contributor
Author
|
I was actually looking for the option to require squash yesterday and couldn't find it. Just looked again and remembered where it was. Thanks! |
dtoki
approved these changes
Aug 28, 2020
bmonkman
added a commit
that referenced
this pull request
Oct 10, 2020
#72) * Add automatic creation of elasticsearch indices and policies after applying. ES cluster is internal so this has to be done via a container in k8s. * Switch pushd to cd * Update templates/scripts/elasticsearch-logging.sh Co-authored-by: David Cheung <[email protected]> * Update templates/terraform/README.md Co-authored-by: David Cheung <[email protected]> * Improved error and env handling in elasticsearch setup, changed default instance types for ES clusters * Fix creating more than one cluster per account Co-authored-by: David Cheung <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…plying.
ES cluster is internal so this has to be done via a container in k8s.
It would be nice to have this tied in to the terraform but the user running TF won't be able to reach the ES cluster.