Add support for sending k8s logs to elasticsearch via fluentd.#67
Merged
Add support for sending k8s logs to elasticsearch via fluentd.#67
Conversation
davidcheung
approved these changes
Aug 25, 2020
| source = "./logging/kibana" | ||
| environment = var.environment | ||
| region = var.region | ||
| cluster_name = "${var.project}-${var.environment}-logging" |
Contributor
There was a problem hiding this comment.
would https://github.com/commitdev/zero-aws-eks-stack/blob/526ba45b4fc21b1c08f0a270351b522f99aec4e5/templates/kubernetes/terraform/modules/kubernetes/logging/kibana/variables.tf need to have cluster_name? maybe its meant to be elasticsearch_domain? since it doesn't have a default
Contributor
Author
There was a problem hiding this comment.
Yes it is, thanks.
dtoki
approved these changes
Aug 25, 2020
bmonkman
added a commit
that referenced
this pull request
Oct 10, 2020
…gging Add support for sending k8s logs to elasticsearch via fluentd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will add support for adding ES indices, index management, etc. in a subsequent PR.
resolves #66