Conversation
bmonkman
reviewed
Aug 13, 2020
| # Reference the cert validations only so it becomes a dependency | ||
| tags = { | ||
| "certs-validated" = join(",", var.certificate_validations) | ||
| # join with realy used char - easier delimiter to indentify; |
Contributor
There was a problem hiding this comment.
A couple typos in here. Also how about just remove this comment and use a dash. The comment and the @ make it look like this has some special significance, but really people should pay attention only to the above comment which indicates that the value doesn't matter.
bmonkman
approved these changes
Aug 13, 2020
bmonkman
pushed a commit
that referenced
this pull request
Oct 10, 2020
* add root domain to s3 buckets * fix domain tag naming validation error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #59
related to commitdev/zero#222