Skip to content

User input validation#57

Merged
dtoki merged 5 commits intomasterfrom
cmd-validate
Aug 6, 2020
Merged

User input validation#57
dtoki merged 5 commits intomasterfrom
cmd-validate

Conversation

@dtoki
Copy link
Copy Markdown
Contributor

@dtoki dtoki commented Aug 5, 2020 •
edited
Loading

Related too commitdev/zero#226
Closes #56

My approach to updating only the environment variables in main.tf is not working yet. attempting to update the kubeconfig fails about 12 mins ⏰ in see log: 👇

module.production.module.eks.data.aws_eks_cluster_auth.cluster: Refreshing state...
module.production.module.eks.data.aws_eks_cluster.cluster: Refreshing state...
module.production.module.eks.module.eks.kubernetes_config_map.aws_auth[0]: Creating...
module.production.module.eks.module.eks.kubernetes_config_map.aws_auth[0]: Still creating... [10s elapsed]
module.production.module.eks.module.eks.kubernetes_config_map.aws_auth[0]: Creation complete after 15s [id=kube-system/aws-auth]
module.production.module.eks.module.eks.data.null_data_source.node_groups[0]: Refreshing state...

Apply complete! Resources: 75 added, 0 changed, 0 destroyed.
Releasing state lock. This may take a few moments...
aws eks --region us-west-2 update-kubeconfig --name dtoki-infra-006-production-us-west-2

An error occurred (ResourceNotFoundException) when calling the DescribeCluster operation: No cluster found for name: dtoki-infra-006-production-us-west-2.
make[1]: *** [update-k8s-conf] Error 254
make: *** [run] Error 2
2020/08/05 09:46:59 Executing command failed: exit status 2

cc @davidcheung have some insight on a tf template I might have missed that doesn't use the environment config in main.tf as input to run commands against the eks cluster?

@dtoki dtoki marked this pull request as ready for review August 5, 2020 21:56
@dtoki dtoki requested review from bmonkman and davidcheung August 5, 2020 21:56
davidcheung
davidcheung reviewed Aug 6, 2020
View reviewed changes
@dtoki dtoki merged commit 3e8852e into master Aug 6, 2020
@dtoki dtoki deleted the cmd-validate branch August 6, 2020 23:23
bmonkman pushed a commit that referenced this pull request Oct 10, 2020
@dtoki
User input validation (#57)
5bb2976 
* adds support for field validation

* shorten appended cluster-name suffix

* production -> prod

* staging -> stage

* update env

* update readme

* shorten rds secret env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@davidcheung davidcheung davidcheung left review comments

@bmonkman bmonkman bmonkman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add validation to modules fields

3 participants

@dtoki @bmonkman @davidcheung