ZERO138 update module name, add summary to makefile#48
Merged
Conversation
bmonkman
approved these changes
Jun 27, 2020
davidcheung
reviewed
Jun 29, 2020
| @@ -1,4 +1,4 @@ | |||
| name: aws-eks-stack | |||
Contributor
There was a problem hiding this comment.
👍 didn't realize the other modules depends on zero-aws-eks-stack, was wondering why they weren't running haha
bmonkman
reviewed
Jun 29, 2020
| @echo "zero-aws-eks-stack:" | ||
| @echo "- Repository URL: ${REPOSITORY}" | ||
| @echo "- To see your kubernetes clusters, run: 'kubectl config get-contexts'" | ||
| @echo "- To switch to a cluster, use the NAME from the previous command in 'kubectl config use-context NAME'" |
Contributor
There was a problem hiding this comment.
Actually why don't we just show them the correct cluster name here?
Contributor
Author
There was a problem hiding this comment.
You want to see separate kubectl config use-context's for each environment that is applied?
bmonkman
pushed a commit
that referenced
this pull request
Oct 10, 2020
ZERO138 update module name, add summary to makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.