Added features necessary to support the new zero apply command#45
Merged
Added features necessary to support the new zero apply command#45
Conversation
Added optional auto approve in make targets Added checking for existing resources and skipping bootstrap steps Added random seed for secret suffixes Upgraded EKS version to 1.16 and module to 12.1.0
cjhawkins
reviewed
Jun 23, 2020
zero-module.yml
Outdated
| execute: aws ssm get-parameters --names /aws/service/eks/optimized-ami/1.15/amazon-linux-2/recommended/image_id --region $region --query "Parameters[0].Value" | tr -d '"' | ||
| - field: eksWorkerAMI | ||
| label: EKS Worker EC2 AMI ID | ||
| execute: aws ssm get-parameters --names /aws/service/eks/optimized-ami/1.15/amazon-linux-2/recommended/image_id --region $region --query "Parameters[0].Value" | tr -d '"' |
Contributor
There was a problem hiding this comment.
Should this be checking /aws/service/eks/optimized-ami/1.16/
cjhawkins
reviewed
Jun 23, 2020
| source = "../../modules/secret" | ||
|
|
||
| name_prefix = "ci-user-aws-keys" | ||
| name = "ci-user-aws-keys<% index .Params `randomSeed` %>" |
Contributor
There was a problem hiding this comment.
Just a general question... is randomSeed used to create a unique namespace that modules share for secrets, or does it actually get used as a seed in random number generation by the modules?
Contributor
Author
There was a problem hiding this comment.
It just gets used as a suffix for the secret name, as secrets have an annoying behaviour where they are not fully deleted, so if you delete a secret and then try to use the same name again it fails. Not a big deal in the real world but it's annoying for testing.
cjhawkins
approved these changes
Jun 23, 2020
bmonkman
added a commit
that referenced
this pull request
Oct 10, 2020
Added features necessary to support the new zero apply command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added optional auto approve in make targets
Added checking for existing resources and skipping bootstrap steps
Added random seed for secret suffixes
Upgraded EKS version to 1.16 and module to 12.1.0