Skip to content

Removed kube2iam and added support for IRSA#4

Merged
bmonkman merged 4 commits intomasterfrom
remove-kube2iam
Apr 14, 2020
Merged

Removed kube2iam and added support for IRSA#4
bmonkman merged 4 commits intomasterfrom
remove-kube2iam

Conversation

@bmonkman
Copy link
Copy Markdown
Contributor

@bmonkman bmonkman commented Apr 8, 2020

Removed kube2iam and all references
Added IRSA support to cloudwatch agent, fluentd, and external-dns
Updated some external-dns settings
Upgraded to the most recent EKS module
Upgraded to the newest EKS version and AMI
Renamed and standardized some role names

Removed kube2iam and all references
Added IRSA support to cloudwatch agent, fluentd, and external-dns
Updated some external-dns settings
Upgraded to the most recent EKS module
Upgraded to the newest EKS version and AMI
Renamed and standardized some role names
@bmonkman
Copy link
Copy Markdown
Contributor Author

bmonkman commented Apr 8, 2020

Still want to fill in the readme a bit more and remove the CNI role from the workers, and instead add IRSA support to the aws-node daemonset.

}

security_context {
fs_group = 65534
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required for applications inside the container to be able to access the token file that gets mounted

eks_worker_asg_min_size = 2
eks_worker_asg_max_size = 6
eks_cluster_version = "1.15"
eks_worker_instance_type = "t3.medium"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t2.small doesn't have enough network interfaces to be very useful even on staging.

# https://us-east-1.console.aws.amazon.com/systems-manager/parameters/%252Faws%252Fservice%252Feks%252Foptimized-ami%252F1.14%252Famazon-linux-2%252Frecommended%252Fimage_id/description?region=us-east-1
eks_worker_ami = "ami-07be7092831897fd6"
# https://us-east-1.console.aws.amazon.com/systems-manager/parameters/%252Faws%252Fservice%252Feks%252Foptimized-ami%252F1.15%252Famazon-linux-2%252Frecommended%252Fimage_id/description?region=us-east-1
eks_worker_ami = "ami-0e710550577202c55"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At one point the code was actually populating the correct AMI here based on the region you chose, but it looks like that was removed. This will be a manual change people will have to make depending on the region they choose which is not great.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that. I've more or less started a whole new implementation on the template parser / writer to be way less fancy and a lot more predictable. Might make sense for us to flag these with comments in-line so we can fix it up as we go. This repository is the bulk of the value.

private_subnets = ["10.10.32.0/19", "10.10.64.0/19", "10.10.96.0/19"]
public_subnets = ["10.10.1.0/24", "10.10.2.0/24", "10.10.3.0/24"]
database_subnets = ["10.10.10.0/24", "10.10.11.0/24", "10.10.12.0/24"]
azs = ["${var.region}a", "${var.region}b"] # Most regions have 3+ azs
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduced to 2 AZs. The extra one is just extra cost without much benefit for smaller companies.

# TODO, determine if this should be true/false
manage_aws_auth = true
# Unfortunately fluentd doesn't yet support oidc auth so we need to grant it to the worker nodes
workers_additional_policies = ["arn:aws:iam::aws:policy/CloudWatchAgentServerPolicy"]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bit of a pain. Hopefully the fluentd cloudwatch plugin is updated soon to support it.

@bmonkman bmonkman merged commit 2c8e22e into master Apr 14, 2020
@bmonkman bmonkman deleted the remove-kube2iam branch April 14, 2020 00:19
bmonkman added a commit that referenced this pull request Oct 10, 2020
Removed kube2iam and added support for IRSA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants