Skip to content

#33: Use an ALIAS record instead of a CNAME for cloudfront distributi… #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmonkman merged 1 commit into from
May 4, 2020
Merged

#33: Use an ALIAS record instead of a CNAME for cloudfront distributi… #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 35 additions & 5 deletions terraform/modules/s3_hosting/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,43 @@ resource "aws_cloudfront_distribution" "client_assets_distribution" {
}
}

# Subdomain to point at CF
resource "aws_route53_record" "client_assets" {
for_each = var.buckets
locals {
# Find buckets that are the domain apex. These need to have A ALIAS records.
rootDomainBuckets = [
for bucket in var.buckets:
bucket if length(regexall("\\.", bucket)) == 1
]

# Find buckets that are subdomains. These can have CNAME records.
subDomainBuckets = [
for bucket in var.buckets:
bucket if length(regexall("\\.", bucket)) > 1
]

}

# Root domains to point at CF
resource "aws_route53_record" "client_assets_root" {
count = length(local.rootDomainBuckets)

zone_id = var.route53_zone_id
name = local.rootDomainBuckets[count.index]
type = "A"

alias {
name = aws_cloudfront_distribution.client_assets_distribution[local.rootDomainBuckets[count.index]].domain_name
zone_id = aws_cloudfront_distribution.client_assets_distribution[local.rootDomainBuckets[count.index]].hosted_zone_id
evaluate_target_health = false
}
}

# Subdomains to point at CF
resource "aws_route53_record" "client_assets_subdomain" {
count = length(local.subDomainBuckets)

zone_id = var.route53_zone_id
name = each.value
name = local.subDomainBuckets[count.index]
type = "CNAME"
ttl = "120"
records = [aws_cloudfront_distribution.client_assets_distribution[each.value].domain_name]
records = [aws_cloudfront_distribution.client_assets_distribution[local.subDomainBuckets[count.index]].domain_name]
}