Automate creation of ACM cert and R53 domain#3
Merged
Conversation
Contributor
Author
|
Going to add optional creation of a pretty name for CF. |
Contributor
Author
|
On second thought I'm not going to make it optional. It doesn't make much sense to leave that out because without a domain pointing at this stuff it's kind of pointless.. |
Renamed domain to certificate Allow multiple certs per call to cert module Added cert validation as a dependency so other modules can wait for it to be ready
trevoro
approved these changes
Apr 7, 2020
Contributor
trevoro
left a comment
trevoro
left a comment
There was a problem hiding this comment.
All looks good at a glance; hard to test :p
The only thing I'd like to start doing after this PR is documenting if anything changes from a manual operations perspective. So for example if I have to setup a route53 domain, just add some kind of "Steps Required" section to the README. Obviously not required for this PR but just wanted to share in case you felt like adding it in early. Thanks for all your work on this!
bmonkman
added a commit
that referenced
this pull request
Oct 10, 2020
Automate creation of ACM cert and R53 domain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.