Change parameter names to fit new format from the doc we are working …#27
Merged
Change parameter names to fit new format from the doc we are working …#27
Conversation
…off, and so zero.yml can be shared between all projects
Direside
approved these changes
Apr 28, 2020
trevoro
reviewed
Apr 28, 2020
| productionBackendHost: api.domain.com | ||
| stagingHostRoot: domain-staging.com | ||
| stagingFrontendHost: domain-staging.com | ||
| stagingBackendHost: api.domain-staging.com |
Contributor
There was a problem hiding this comment.
More like "lets talk about this later" but this is the kind of place where we'll benefit by having these configuration values but also providing reasonable defaults too.
Contributor
Author
There was a problem hiding this comment.
I think these are already good suggestions. Use different domains for staging and production, have the front end served from the root, provide your backend on a subdomain called api
trevoro
approved these changes
Apr 28, 2020
bmonkman
added a commit
that referenced
this pull request
Oct 10, 2020
Change parameter names to fit new format from the doc we are working …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…off, and so zero.yml can be shared between all projects