Fix the kubernetes admin role, pull some of the iam stuff out into a …#23
Merged
Fix the kubernetes admin role, pull some of the iam stuff out into a …#23
Conversation
…reating the cloudfront dist so it becomes a true dependency to prevent a race condition.
davidcheung
reviewed
Apr 28, 2020
| } | ||
|
|
||
| # Reference the cert validations only so it becomes a dependency | ||
| tags = { |
Contributor
There was a problem hiding this comment.
nice, didnt know you could do that
Contributor
Author
There was a problem hiding this comment.
TF builds a big dependency graph so it can decide what can be run in parallel and what needs to be serial. The problem here though is just that it's too smart. I thought just by providing the validations resource as an argument to this module it would create a dependency, but it looks like we actually have to use it inside the module too.
davidcheung
approved these changes
Apr 28, 2020
davidcheung
reviewed
Apr 28, 2020
|
|
||
| principals { | ||
| type = "AWS" | ||
| identifiers = [data.aws_iam_user.ci_user.arn] |
Contributor
There was a problem hiding this comment.
it can access the ci_user from the main file right?
Contributor
Author
There was a problem hiding this comment.
Yes, since they are in the same directory. Though it looks like I forgot to remove something from main that I copied over. Thanks!
bmonkman
added a commit
that referenced
this pull request
Oct 10, 2020
Fix the kubernetes admin role, pull some of the iam stuff out into a …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…separate tf file