Merged
Conversation
bmonkman
reviewed
Apr 20, 2020
Contributor
There was a problem hiding this comment.
Hmm we could have left this in the secrets section. It still might be beneficial to have that for secrets like this that we just want to put into secrets manager and forget about. I know it's another step and that's annoying, but we should be careful how many secrets get put into the TF state.
bmonkman
reviewed
Apr 20, 2020
Contributor
There was a problem hiding this comment.
Could you add a default for this? Since it's really only for testing and not something that normal users should care about we should try to keep it under the hood as much as possible.
davidcheung
force-pushed
the
merge-secret
branch
2 times, most recently
from
28bf305 to
e6f125b
Compare
bmonkman
approved these changes
Apr 21, 2020
secret names are unique and long-lived(soft delete) and names are not reusable, so for development/shared env purposes it will be nicer to have secrets use a name_prefix to avoid name conflicts Note: originally secret was put in a separate TF state so the secrets can be referenced by name only, but RDS does not support secret-manager
davidcheung
force-pushed
the
merge-secret
branch
from
72917be to
c10377f
Compare
davidcheung
added a commit
that referenced
this pull request
Apr 21, 2020
while #14 was being merged, i made a non-declared reference which broke the secret from being created
This was referenced Apr 21, 2020
bmonkman
pushed a commit
that referenced
this pull request
Oct 10, 2020
while #14 was being merged, i made a non-declared reference which broke the secret from being created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
secret names are unique and long-lived(soft delete) and
names are not reusable, so for development/shared env purposes it
will be nicer to have secrets use a name_prefix to avoid name conflicts
Note: originally secret was put in a separate TF state so the secrets
can be referenced by name only, but RDS does not support secret-manager