Conversation
bmonkman
reviewed
Sep 28, 2020
| # get name | ||
| echo -n "Enter your name: " | ||
| read name | ||
| echo -n "Enter your name: " && read name |
Contributor
There was a problem hiding this comment.
Let's print the name of the cluster before this so they know which context they are using. Otherwise they don't really know where they are adding the user to, and I don't think we explicitly tell them to change their kube context.
bmonkman
reviewed
Sep 28, 2020
templates/scripts/add-vpn-user.sh
Outdated
| [[ -z "$vpc_cidr" ]] && vpc_cidr = "10.10.0.0/16" | ||
|
|
||
| # get DB server | ||
| K8S_DBSERVER=database.${NAMESPACE}.svc.cluster.local |
Contributor
There was a problem hiding this comment.
Let's take this out. It's extra complexity just to show an example comment. Let's just leave the comment as an example like <rds mysql hostname>
bmonkman
reviewed
Sep 28, 2020
templates/scripts/add-vpn-user.sh
Outdated
| echo | ||
| echo "When it is running you should be able to access internal resources, e.g. mysql -h 10.10.10.123" | ||
| echo "When it is running you should be able to access internal resources, eg. database server:" | ||
| echo " with Kubernetes cluster DNS, run:" |
Contributor
There was a problem hiding this comment.
Let's not show both of these, it will just confuse people who don't have enough context. We can just have an example like <aws rds hostname>
If anything, you could mention that you can connect to things inside both the VPC and the kubernetes cluster.
bmonkman
reviewed
Sep 28, 2020
bmonkman
reviewed
Sep 28, 2020
bmonkman
reviewed
Sep 29, 2020
| fi | ||
| EXEC="kubectl -n vpn exec -it $POD -- /bin/bash -c" | ||
|
|
||
| function k8s_exec() { |
bmonkman
approved these changes
Sep 29, 2020
bmonkman
added a commit
that referenced
this pull request
Oct 10, 2020
* support DNS for VPN client * fix hardcode * enhancement on display etc. * Update add-vpn-user.sh Co-authored-by: Bill Monkman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.