docs: sendgrid example and explaination#105
Merged
davidcheung merged 2 commits intomainfrom Sep 22, 2020
Merged
Conversation
this may not be super practical since most users will incorporate mail into their application, so the block is more explaining the state of resources, indicating it is ready to send an email
bmonkman
reviewed
Sep 22, 2020
templates/README.md
Outdated
| ... | ||
|
|
||
| #### Sending Email with Sendgrid | ||
| Setup: If you initialized your infrastructure with a sendgridApiKey, you should have a verified domain with Sendgrid once your infrastructure is setup. We should have created for you 3 route53 entries, and [verified you domain with sendgrid][sendgrid-domain-verification] |
Contributor
There was a problem hiding this comment.
Should be "We should have created 3 route53 entries for you and verified your domain with sendgrid"
bmonkman
approved these changes
Sep 22, 2020
bmonkman
pushed a commit
that referenced
this pull request
Oct 10, 2020
* docs: sendgrid example and explaination this may not be super practical since most users will incorporate mail into their application, so the block is more explaining the state of resources, indicating it is ready to send an email * fixup! docs: sendgrid example and explaination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this may not be super practical since most users will incorporate mail
into their application code, so the block is more explaining the state of
resources, indicating it is ready to send an email