Merged
Conversation
GrooveStomp
force-pushed
the
zero-235
branch
4 times, most recently
from
dd26d3d to
cfb0ded
Compare
GrooveStomp
force-pushed
the
zero-235
branch
from
0a185a0 to
482b912
Compare
GrooveStomp
force-pushed
the
zero-235
branch
2 times, most recently
from
687af9f to
c008f5c
Compare
bmonkman
reviewed
Sep 28, 2020
bmonkman
approved these changes
Sep 28, 2020
GrooveStomp
force-pushed
the
zero-235
branch
from
6ce29e0 to
c008f5c
Compare
improvement: leverage multiple domains support for file uploads backend fix: pin aws provider version - specify required hashicorp/aws version for aws provider - add 'signed_urls' to hosted_domains variable - conditionally define files bucket as part of hosted_domains application_iam_policy - set 'domain_name' to local var - add new s3 get/put policy
GrooveStomp
force-pushed
the
zero-235
branch
from
c008f5c to
3d22aaa
Compare
bmonkman
pushed a commit
that referenced
this pull request
Oct 10, 2020
improvement: leverage multiple domains support for file uploads backend fix: pin aws provider version - specify required hashicorp/aws version for aws provider - add 'signed_urls' to hosted_domains variable - conditionally define files bucket as part of hosted_domains application_iam_policy - set 'domain_name' to local var - add new s3 get/put policy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: correct authorization for s3 access for backend service
improvement: leverage multiple domains support for file uploads backend
fix: pin aws provider version
application_iam_policy
https://app.zenhub.com/workspaces/commit-zero-5da8decc7046a60001c6db44/issues/commitdev/zero/235