fix: missing referenced variable

davidcheung · davidcheung · commit b923778d478a · 2020-04-21T17:34:00.000-04:00
while #14 was being merged, i made a non-declared reference which broke the secret from being created
diff --git a/terraform/bootstrap/secrets/main.tf b/terraform/bootstrap/secrets/main.tf
@@ -6,9 +6,13 @@ terraform {
   required_version = ">= 0.12"	
 }	
 
+locals {
+  project = "<% .Name %>"
+}
+
 # Create the CI User	
 resource "aws_iam_user" "ci_user" {	
-  name = "${var.project}-ci-user"	
+  name = "${local.project}-ci-user"	
 }	
 
 # Create a keypair to be used by CI systems	
diff --git a/terraform/modules/environment/main.tf b/terraform/modules/environment/main.tf
@@ -97,5 +97,5 @@ module "ecr" {
 
   environment       = var.environment
   ecr_repositories  = var.ecr_repositories
-  ecr_principals    = [aws_iam_user.ci_user.arn]
+  ecr_principals    = [data.aws_iam_user.ci_user.arn]
 }

Original file line number	Diff line number	Diff line change
`@@ -6,9 +6,13 @@ terraform {`
`6`	`6`	`required_version = ">= 0.12"`
`7`	`7`	`}`
`8`	`8`
	`9`	`+locals {`
	`10`	`+ project = "<% .Name %>"`
	`11`	`+}`
	`12`	`+`
`9`	`13`	`# Create the CI User`
`10`	`14`	`resource "aws_iam_user" "ci_user" {`
`11`		`- name = "${var.project}-ci-user"`
	`15`	`+ name = "${local.project}-ci-user"`
`12`	`16`	`}`
`13`	`17`
`14`	`18`	`# Create a keypair to be used by CI systems`
Original file line number	Diff line number	Diff line change
`@@ -97,5 +97,5 @@ module "ecr" {`
`97`	`97`
`98`	`98`	`environment = var.environment`
`99`	`99`	`ecr_repositories = var.ecr_repositories`
`100`		`- ecr_principals = [aws_iam_user.ci_user.arn]`
	`100`	`+ ecr_principals = [data.aws_iam_user.ci_user.arn]`
`101`	`101`	`}`