Add testimonials section with carousel#45
Merged
jasondippel merged 2 commits intolaunchfrom Jan 29, 2021
Merged
Conversation
julie-huang
reviewed
Jan 29, 2021
| const DOT_SIZE = rem('18px') | ||
| const DOT_SIZE_MOBILE = rem('24px') | ||
|
|
||
| const Root = styled.div` |
Contributor
There was a problem hiding this comment.
Maybe we want to move styles to components/testimonials/styles.js
What you guys think? @superkhau @timothy-wan
Contributor
There was a problem hiding this comment.
Well styled components are laid out like this anyway. I'm good leaving like this
julie-huang
reviewed
Jan 29, 2021
julie-huang
suggested changes
Jan 29, 2021
Contributor
julie-huang
left a comment
julie-huang
left a comment
There was a problem hiding this comment.
Minor stuff, will approve after getting some second opinion after styles convention
superkhau
approved these changes
Jan 29, 2021
julie-huang
approved these changes
Jan 29, 2021
jasondippel
added a commit
that referenced
this pull request
Jan 29, 2021
* Add testimonials section with carousel * Alphabetize exports
jasondippel
added a commit
that referenced
this pull request
Jan 29, 2021
* Add testimonials section with carousel * Alphabetize exports
jasondippel
added a commit
that referenced
this pull request
Feb 1, 2021
* Add testimonials section with carousel * Alphabetize exports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Screenshots