Skip to content

Application form select field - disabled typing and fixed menu closing after selection on Android Chrome#298

Merged
robyn3choi merged 1 commit intolaunchfrom
292-android
Apr 20, 2021
Merged

Application form select field - disabled typing and fixed menu closing after selection on Android Chrome#298
robyn3choi merged 1 commit intolaunchfrom
292-android

Conversation

@robyn3choi
Copy link
Copy Markdown

@robyn3choi robyn3choi commented Apr 20, 2021 •
edited
Loading

Reminder

Please ensure the following criteria is met for this PR. It will help others review your PR and provide confidence things work as expected.

  • CI is green
  • Link to any related issues
  • Received at least 1 approval from core members
  • Made sure that changes are obvious for the reviewer (ex meaningful title and commit messages, comments in code or PR where appropriate, screenshots, etc.)

What Changed?

  • No longer able to type into this field (this was especially annoying on mobile because the keyboard would keep showing up)
  • Fixed issue where menu kept closing after selecting an item on Android Chrome
20210420_135437.mp4

Related Issue: #294

@robyn3choi robyn3choi linked an issue Apr 20, 2021 that may be closed by this pull request
Android Chrome - the application form's multiselect field is hard to use on mobile #294
Closed
@robyn3choi robyn3choi merged commit ce368a8 into launch Apr 20, 2021
@robyn3choi robyn3choi deleted the 292-android branch April 20, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ALukonin ALukonin ALukonin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Android Chrome - the application form's multiselect field is hard to use on mobile

2 participants

@robyn3choi @ALukonin