Skip to content

refactor(media): change media components api to simplify using static media#207

Merged
alebiavati merged 1 commit intolaunchfrom
simplify-media-components
Apr 7, 2021
Merged

refactor(media): change media components api to simplify using static media#207
alebiavati merged 1 commit intolaunchfrom
simplify-media-components

Conversation

@alebiavati
Copy link
Copy Markdown
Contributor

Reminder

Please ensure the following criteria is met for this PR. It will help others review your PR and provide confidence things work as expected.

  • CI is green
  • Link to any related issues
  • Received at least 1 approval from core members
  • Made sure that changes are obvious for the reviewer (ex meaningful title and commit messages, comments in code or PR where appropriate, screenshots, etc.)

What Changed?

Simplify API for importing static images and videos. Now importing an image stored at /static/my-image-name.png can be done more easily like so:

import { StaticImage } from 'components'

<StaticImage name="my-image-name.png" alt="My image" />

@alebiavati alebiavati merged commit c1f5aab into launch Apr 7, 2021
@alebiavati alebiavati deleted the simplify-media-components branch April 7, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants