Skip to content

Fix the failing e2e test and added an additional step#153

Merged
adriandelisle merged 3 commits intolaunchfrom
fix-launch-e2e-test
Mar 8, 2021
Merged

Fix the failing e2e test and added an additional step#153
adriandelisle merged 3 commits intolaunchfrom
fix-launch-e2e-test

Conversation

@adriandelisle
Copy link
Copy Markdown
Contributor

@adriandelisle adriandelisle commented Mar 5, 2021 •
edited
Loading

Reminder

Please ensure the following criteria is met for this PR. It will help others review your PR and provide confidence things work as expected.

  • CI is green
  • Link to any related issues
  • Received at least 1 approval from core members
  • Made sure that changes are obvious for the reviewer (ex meaningful title and commit messages, comments in code or PR where appropriate, screenshots, etc.)

What Changed?

  • Fixed the selectors for the e2e test and added a step to go to the new apply page.
  • Renamed the test_lint job to lint as it only lints
  • Adding e2e testing on feature branches

Related Issue: None

@adriandelisle adriandelisle force-pushed the fix-launch-e2e-test branch 12 times, most recently from 8075bd0 to 7121b7b Compare March 6, 2021 00:22
@adriandelisle adriandelisle changed the title Fixed the failing e2e test and added an additional step Fix the failing e2e test and added an additional step Mar 6, 2021
@adriandelisle adriandelisle merged commit c46bcfb into launch Mar 8, 2021
@adriandelisle adriandelisle deleted the fix-launch-e2e-test branch March 8, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@superkhau superkhau superkhau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adriandelisle @superkhau