fix staging e2e testing (#156)

adriandelisle · web-flow · commit 47b6d0c474de · 2021-03-08T14:34:17.000-08:00
* fix staging e2e testing

* remove staging e2e debugging on feature branch
diff --git a/components/form/index.js b/components/form/index.js
@@ -123,7 +123,6 @@ const Form = () => {
           />
           <Button
             {...{
-              'data-test-id': 'submitApplicationButton',
               onClick,
             }}
           >
diff --git a/pages/index.js b/pages/index.js
@@ -34,7 +34,7 @@ const Home = () => (
             Commit is designing the future of work and we're putting Engineers
             at the center.
           </Text>
-          <ApplyLink data-test-id='applyButton'>Apply to Join Us</ApplyLink>
+          <ApplyLink>Apply to Join Us</ApplyLink>
         </div>
         <div className={styles.heroSvg}>
           <BracketSvg />
@@ -148,9 +148,10 @@ const Home = () => (
             The Commit Platform
           </Heading>
           <Text sectionText>
-            The Commit Platform replaces the technical interview with deep backgrounds, 
-            matches Software Engineers with relevant startups, and connect Engineers 
-            with peers for interest sharing or technical support.
+            The Commit Platform replaces the technical interview with deep
+            backgrounds, matches Software Engineers with relevant startups, and
+            connect Engineers with peers for interest sharing or technical
+            support.
           </Text>
         </div>
         <div className={styles.platformFlex}>
@@ -174,11 +175,12 @@ const Home = () => (
             </div>
             <div className={styles.profileColumnRight}>
               <Heading variant={h3} className={styles.platformTitle}>
-                Platform profile 
+                Platform profile
               </Heading>
               <Text sectionText className={styles.platformDescription}>
-                Get the latest community events, news and updates. Most importantly, begin to look for startup 
-                opportunities recommended specifically for you. This is also where engineers begin to 
+                Get the latest community events, news and updates. Most
+                importantly, begin to look for startup opportunities recommended
+                specifically for you. This is also where engineers begin to
                 connect with their peers and join interest-based groups.
               </Text>
             </div>
@@ -267,4 +269,3 @@ const Home = () => (
 )
 
 export default Home
-
diff --git a/tests/index.e2e.js b/tests/index.e2e.js
@@ -2,24 +2,29 @@ import puppeteer from 'puppeteer'
 
 import { config, PageObjectModel } from '../helpers/e2e'
 
+const APPLY_SELECTOR = '[href="/apply"]'
+const SUBMIT_APPLICATION_SELECTOR = 'form button'
 class LandingPage extends PageObjectModel {
   async checkApplyButtonExists() {
     const buttonText = await this.getTextBySelector({
-      selector: '[data-test-id="applyButton"]',
+      selector: APPLY_SELECTOR,
     })
     await expect(buttonText).toBeTruthy()
   }
 }
 
 describe('LandingPage', () => {
   let browser
+  let context
   let page
   let landingPage
   const filenamePrefix = 'landing'
 
   beforeAll(async () => {
     browser = await puppeteer.launch(config.puppeteer)
-    page = await browser.newPage()
+    context = await browser.createIncognitoBrowserContext()
+    page = await context.newPage()
+    console.log('Host: ', config.host)
     landingPage = new LandingPage(page)
   })
 
@@ -37,10 +42,10 @@ describe('LandingPage', () => {
 
   it('it goes to the apply page on click of apply button', async () => {
     await landingPage.clickSelector({
-      selector: '[data-test-id="applyButton"]',
+      selector: APPLY_SELECTOR,
     })
     const buttonText = await landingPage.getTextBySelector({
-      selector: '[data-test-id="submitApplicationButton"]',
+      selector: SUBMIT_APPLICATION_SELECTOR,
     })
     expect(buttonText).toBeTruthy()
     await landingPage.saveScreenshot({

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,6 @@ const Form = () => {`
`123`	`123`	`/>`
`124`	`124`	`<Button`
`125`	`125`	`{...{`
`126`		`- 'data-test-id': 'submitApplicationButton',`
`127`	`126`	`onClick,`
`128`	`127`	`}}`
`129`	`128`	`>`