🐛 Fix form field regression (fastapi#12194)

tonnico · web-flow · commit 88d4f2cb1814 · 2024-09-13T11:51:00.000+02:00
diff --git a/fastapi/dependencies/utils.py b/fastapi/dependencies/utils.py
@@ -788,7 +788,7 @@ async def process_fn(
                     tg.start_soon(process_fn, sub_value.read)
             value = serialize_sequence_value(field=field, value=results)
         if value is not None:
-            values[field.name] = value
+            values[field.alias] = value
     for key, value in received_body.items():
         if key not in values:
             values[key] = value
diff --git a/tests/test_forms_single_model.py b/tests/test_forms_single_model.py
@@ -3,7 +3,7 @@
 from dirty_equals import IsDict
 from fastapi import FastAPI, Form
 from fastapi.testclient import TestClient
-from pydantic import BaseModel
+from pydantic import BaseModel, Field
 from typing_extensions import Annotated
 
 app = FastAPI()
@@ -14,6 +14,7 @@ class FormModel(BaseModel):
     lastname: str
     age: Optional[int] = None
     tags: List[str] = ["foo", "bar"]
+    alias_with: str = Field(alias="with", default="nothing")
 
 
 @app.post("/form/")
@@ -32,6 +33,7 @@ def test_send_all_data():
             "lastname": "Sanchez",
             "age": "70",
             "tags": ["plumbus", "citadel"],
+            "with": "something",
         },
     )
     assert response.status_code == 200, response.text
@@ -40,6 +42,7 @@ def test_send_all_data():
         "lastname": "Sanchez",
         "age": 70,
         "tags": ["plumbus", "citadel"],
+        "with": "something",
     }
 
 
@@ -51,6 +54,7 @@ def test_defaults():
         "lastname": "Sanchez",
         "age": None,
         "tags": ["foo", "bar"],
+        "with": "nothing",
     }
 
 
@@ -100,13 +104,13 @@ def test_no_data():
                     "type": "missing",
                     "loc": ["body", "username"],
                     "msg": "Field required",
-                    "input": {"tags": ["foo", "bar"]},
+                    "input": {"tags": ["foo", "bar"], "with": "nothing"},
                 },
                 {
                     "type": "missing",
                     "loc": ["body", "lastname"],
                     "msg": "Field required",
-                    "input": {"tags": ["foo", "bar"]},
+                    "input": {"tags": ["foo", "bar"], "with": "nothing"},
                 },
             ]
         }
