Fixed #10397 (FP constParameter - implementing an interface)

danmar · danmar · commit e95395e5f087 · 2021-08-10T15:37:59.000+02:00
diff --git a/lib/checkother.cpp b/lib/checkother.cpp
@@ -1501,6 +1501,10 @@ void CheckOther::checkConstPointer()
         nonConstPointers.insert(tok->variable());
     }
     for (const Variable *p: pointers) {
+        if (p->isArgument()) {
+            if (!p->scope() || !p->scope()->function || p->scope()->function->isImplicitlyVirtual(true) || p->scope()->function->hasVirtualSpecifier())
+                continue;
+        }
         if (nonConstPointers.find(p) == nonConstPointers.end())
             constVariableError(p, nullptr);
     }
diff --git a/test/testother.cpp b/test/testother.cpp
@@ -2746,6 +2746,10 @@ class TestOther : public TestFixture {
               "  w = 1;\n"
               "}");
         ASSERT_EQUALS("", errout.str());
+
+        check("class Base { virtual void dostuff(int *p) = 0; };\n" // #10397
+              "class Derived: public Base { int x; void dostuff(int *p) override { x = *p; } };");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void switchRedundantAssignmentTest() {

Original file line number	Diff line number	Diff line change
`@@ -1501,6 +1501,10 @@ void CheckOther::checkConstPointer()`
`1501`	`1501`	`nonConstPointers.insert(tok->variable());`
`1502`	`1502`	`}`
`1503`	`1503`	`for (const Variable *p: pointers) {`
	`1504`	`+ if (p->isArgument()) {`
	`1505`	`+ if (!p->scope() \|\| !p->scope()->function \|\| p->scope()->function->isImplicitlyVirtual(true) \|\| p->scope()->function->hasVirtualSpecifier())`
	`1506`	`+ continue;`
	`1507`	`+ }`
`1504`	`1508`	`if (nonConstPointers.find(p) == nonConstPointers.end())`
`1505`	`1509`	`constVariableError(p, nullptr);`
`1506`	`1510`	`}`