Fix FP leakNoVarFunctionCall with passthrough returns (danmar#3249)

keinflue · web-flow · commit bfa26b5a7232 · 2021-05-08T10:26:10.000+02:00
diff --git a/lib/checkmemoryleak.cpp b/lib/checkmemoryleak.cpp
@@ -996,7 +996,7 @@ void CheckMemoryLeakNoVar::checkForUnreleasedInputArgument(const Scope *scope)
         const Token* tok2 = tok->next()->astParent();
         while (tok2 && tok2->isCast())
             tok2 = tok2->astParent();
-        if (tok2 && tok2->isAssignmentOp())
+        if (Token::Match(tok2, "%assign%|return"))
             continue;
 
         const std::string& functionName = tok->str();
diff --git a/test/testmemleak.cpp b/test/testmemleak.cpp
@@ -2173,6 +2173,11 @@ class TestMemleakNoVar : public TestFixture {
               "    return ret;\n"
               "}");
         ASSERT_EQUALS("", errout.str());
+        
+        check("char *x() {\n"
+              "    return strcpy(malloc(10), \"abc\");\n"
+              "}");
+        ASSERT_EQUALS("", errout.str());
 
         check("void x() {\n"
               "    free(malloc(10));\n"
