Fixed false positive danmar#5004

PKEuS · PKEuS · commit b36a88760885 · 2013-09-03T10:54:10.000+02:00
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -774,7 +774,7 @@ void CheckClass::initializationListUsage()
                     }
                     if (!allowed)
                         continue;
-                    if (!var->isPointer() && (var->type() || Token::Match(var->typeStartToken(), "std :: string|wstring !!::") || (Token::Match(var->typeStartToken(), "std :: %type% <") && !Token::simpleMatch(var->typeStartToken()->linkAt(3), "> ::"))))
+                    if (!var->isPointer() && !var->isReference() && (var->type() || Token::Match(var->typeStartToken(), "std :: string|wstring !!::") || (Token::Match(var->typeStartToken(), "std :: %type% <") && !Token::simpleMatch(var->typeStartToken()->linkAt(3), "> ::"))))
                         suggestInitializationList(tok, tok->str());
                 }
             }
diff --git a/test/testclass.cpp b/test/testclass.cpp
@@ -5475,6 +5475,12 @@ class TestClass : public TestFixture {
                                      "};");
         ASSERT_EQUALS("[test.cpp:3]: (performance) Variable 's' is assigned in constructor body. Consider performing initialization in initialization list.\n", errout.str());
 
+        checkInitializationListUsage("class Fred {\n"
+                                     "    std::string& s;\n" // Message is invalid for references, since their initialization in initializer list is required anyway and behaves different from assignment (#5004)
+                                     "    Fred(const std::string& s) : s(s_) { s = \"foo\"; }\n"
+                                     "};");
+        ASSERT_EQUALS("", errout.str());
+
         checkInitializationListUsage("class Fred {\n"
                                      "    std::vector<int> v;\n"
                                      "    Fred() { v = unknown; }\n"

Original file line number	Diff line number	Diff line change
`@@ -774,7 +774,7 @@ void CheckClass::initializationListUsage()`
`774`	`774`	`}`
`775`	`775`	`if (!allowed)`
`776`	`776`	`continue;`
`777`		`- if (!var->isPointer() && (var->type() \|\| Token::Match(var->typeStartToken(), "std :: string\|wstring !!::") \|\| (Token::Match(var->typeStartToken(), "std :: %type% <") && !Token::simpleMatch(var->typeStartToken()->linkAt(3), "> ::"))))`
	`777`	`+ if (!var->isPointer() && !var->isReference() && (var->type() \|\| Token::Match(var->typeStartToken(), "std :: string\|wstring !!::") \|\| (Token::Match(var->typeStartToken(), "std :: %type% <") && !Token::simpleMatch(var->typeStartToken()->linkAt(3), "> ::"))))`
`778`	`778`	`suggestInitializationList(tok, tok->str());`
`779`	`779`	`}`
`780`	`780`	`}`