CheckBool: Fixed false negative when assigning bool to pointer '; s.p = true; '

danmar · danmar · commit 5c072993e38f · 2013-10-29T16:16:52.000+01:00
diff --git a/lib/checkbool.cpp b/lib/checkbool.cpp
@@ -333,10 +333,13 @@ void CheckBool::checkAssignBoolToPointer()
         const Scope * scope = symbolDatabase->functionScopes[i];
         for (const Token* tok = scope->classStart; tok != scope->classEnd; tok = tok->next()) {
             if (Token::Match(tok, "%var% = %bool% ;")) {
-                // Todo: properly check if there is a deref
+                // check if there is a deref
                 // *x.p = true;  // <- don't warn
                 // x.p = true;   // <- warn
-                if (Token::Match(tok->previous(), "[*.)]"))
+                const Token *prev = tok;
+                while (Token::Match(prev->tokAt(-2), "%var% ."))
+                    prev = prev->tokAt(-2);
+                if (Token::Match(prev->previous(), "[*.)]"))
                     continue;
 
                 // Is variable a pointer?
diff --git a/test/testbool.cpp b/test/testbool.cpp
@@ -111,7 +111,7 @@ class TestBool : public TestFixture {
               "    S s = {0};\n"
               "    s.p = true;\n"
               "}\n");
-        TODO_ASSERT_EQUALS("error", "", errout.str());
+        ASSERT_EQUALS("[test.cpp:6]: (error) Boolean value assigned to pointer.\n", errout.str());
     }
 
     void comparisonOfBoolExpressionWithInt1() {

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ class TestBool : public TestFixture {`
`111`	`111`	`" S s = {0};\n"`
`112`	`112`	`" s.p = true;\n"`
`113`	`113`	`"}\n");`
`114`		`- TODO_ASSERT_EQUALS("error", "", errout.str());`
	`114`	`+ ASSERT_EQUALS("[test.cpp:6]: (error) Boolean value assigned to pointer.\n", errout.str());`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`void comparisonOfBoolExpressionWithInt1() {`