Fixing danmar#3515 (Add samples/id/good|bad.cpp)

aggro80 · aggro80 · commit 5bb956b0ff1d · 2012-01-22T15:52:31.000+02:00
http://sourceforge.net/apps/trac/cppcheck/ticket/3515
diff --git a/runastyle b/runastyle
@@ -29,4 +29,5 @@ astyle $style $options test/*.h
 
 astyle $style $options tools/*.cpp
 astyle $style $options --recursive "samples/*.c"
+astyle $style $options --recursive "samples/*.cpp"
 
diff --git a/samples/arrayIndexOutOfBounds/bad.c b/samples/arrayIndexOutOfBounds/bad.c
@@ -0,0 +1,9 @@
+int main()
+{
+    int a[2];
+    a[0] = 0;
+    a[1] = 0;
+    a[2] = 0;
+    return a[0];
+}
+
diff --git a/samples/arrayIndexOutOfBounds/good.c b/samples/arrayIndexOutOfBounds/good.c
@@ -0,0 +1,9 @@
+int main()
+{
+    int a[3];
+    a[0] = 0;
+    a[1] = 0;
+    a[2] = 0;
+    return a[0];
+}
+
diff --git a/samples/autoVariables/bad.c b/samples/autoVariables/bad.c
@@ -0,0 +1,12 @@
+void foo(int **a)
+{
+    int b = 1;
+    *a = &b;
+}
+
+int main()
+{
+    int *c;
+    foo(&c);
+}
+
diff --git a/samples/autoVariables/good.c b/samples/autoVariables/good.c
@@ -0,0 +1,13 @@
+void foo(int **a)
+{
+    int b = 1;
+    **a = b;
+}
+
+int main()
+{
+    int b;
+    int *c = &b;
+    foo(&c);
+}
+
diff --git a/samples/bufferAccessOutOfBounds/bad.c b/samples/bufferAccessOutOfBounds/bad.c
@@ -0,0 +1,9 @@
+int main()
+{
+    int a[2];
+    int i;
+    for (i = 0; i < 3; i++)
+        a[i] = 0;
+    return a[0];
+}
+
diff --git a/samples/bufferAccessOutOfBounds/good.c b/samples/bufferAccessOutOfBounds/good.c
@@ -0,0 +1,9 @@
+int main()
+{
+    int a[3];
+    int i;
+    for (i = 0; i < 3; i++)
+        a[i] = 0;
+    return a[0];
+}
+
diff --git a/samples/erase/bad.cpp b/samples/erase/bad.cpp
@@ -0,0 +1,15 @@
+#include <vector>
+int main()
+{
+    std::vector<int> items;
+    items.push_back(1);
+    items.push_back(2);
+    items.push_back(3);
+    std::vector<int>::iterator iter;
+    for (iter=items.begin() ; iter!=items.end() ; ++iter) {
+        if (true) {
+            items.erase(iter);
+        }
+    }
+}
+
diff --git a/samples/erase/good.cpp b/samples/erase/good.cpp
@@ -0,0 +1,17 @@
+#include <vector>
+int main()
+{
+    std::vector<int> items;
+    items.push_back(1);
+    items.push_back(2);
+    items.push_back(3);
+    std::vector<int>::iterator iter;
+    for (iter=items.begin(); iter!= items.end();) {
+        if (true) {
+            iter = items.erase(iter);
+        } else {
+            ++iter;
+        }
+    }
+}
+
diff --git a/samples/outOfBounds/bad.c b/samples/outOfBounds/bad.c
@@ -0,0 +1,7 @@
+#include <stdio.h>
+int main()
+{
+    char str[5];
+    snprintf(str, 10, "%s", "abc");
+}
+
diff --git a/samples/outOfBounds/good.c b/samples/outOfBounds/good.c
@@ -0,0 +1,7 @@
+#include <stdio.h>
+int main()
+{
+    char str[10];
+    snprintf(str, 10, "%s", "abc");
+}
+
diff --git a/samples/syntaxError/bad.c b/samples/syntaxError/bad.c
@@ -0,0 +1,6 @@
+int main()
+{
+#ifndef A
+}
+#endif
+
diff --git a/samples/syntaxError/good.c b/samples/syntaxError/good.c
@@ -0,0 +1,6 @@
+int main()
+{
+#ifndef A
+#endif
+}
+

Original file line number	Diff line number	Diff line change
`@@ -29,4 +29,5 @@ astyle $style $options test/*.h`
`29`	`29`
`30`	`30`	`astyle $style $options tools/*.cpp`
`31`	`31`	`astyle $style $options --recursive "samples/*.c"`
	`32`	`+astyle $style $options --recursive "samples/*.cpp"`
`32`	`33`