Fixed danmar#2932 (segmentation fault of cppcheck ( i / i ))

simartin · Daniel Marjam&auml;ki · commit 539c2e5acb02 · 2011-07-24T09:06:38.000+02:00
diff --git a/lib/checkother.cpp b/lib/checkother.cpp
@@ -1094,17 +1094,6 @@ void CheckOther::checkUnsignedDivision()
                 }
             }
         }
-        else if (Token::Match(tok, "|[|=|return|%op% %var% / %var%"))
-        {
-
-            //std::cout << "cicicicic" << std::endl;
-            char sign1 = varsign[tok->tokAt(1)->varId()];
-            char sign2 = varsign[tok->tokAt(3)->varId()];
-            if ((sign1 == 'u' && sign2 == 's') || (sign1 == 's' && sign2 == 'u'))
-            {
-                //udivError(tok);
-            }
-        }
     }
 }
 
diff --git a/test/testdivision.cpp b/test/testdivision.cpp
@@ -64,6 +64,7 @@ class TestDivision : public TestFixture
         TEST_CASE(division7);
         TEST_CASE(division8);
         TEST_CASE(division9);
+        TEST_CASE(division10);
     }
 
     void division1()
@@ -198,6 +199,13 @@ class TestDivision : public TestFixture
         TODO_ASSERT_EQUALS("unsigned division",
                            "", errout.str());
     }
+
+    void division10()
+    {
+        // Ticket: #2932 - don't segfault
+        check("i / i");
+        ASSERT_EQUALS("", errout.str());
+    }
 };
 
 REGISTER_TEST(TestDivision)

Original file line number	Diff line number	Diff line change
`@@ -1094,17 +1094,6 @@ void CheckOther::checkUnsignedDivision()`
`1094`	`1094`	`}`
`1095`	`1095`	`}`
`1096`	`1096`	`}`
`1097`		`- else if (Token::Match(tok, "\|[\|=\|return\|%op% %var% / %var%"))`
`1098`		`- {`
`1099`		`-`
`1100`		`- //std::cout << "cicicicic" << std::endl;`
`1101`		`- char sign1 = varsign[tok->tokAt(1)->varId()];`
`1102`		`- char sign2 = varsign[tok->tokAt(3)->varId()];`
`1103`		`- if ((sign1 == 'u' && sign2 == 's') \|\| (sign1 == 's' && sign2 == 'u'))`
`1104`		`- {`
`1105`		`- //udivError(tok);`
`1106`		`- }`
`1107`		`- }`
`1108`	`1097`	`}`
`1109`	`1098`	`}`
`1110`	`1099`