Conversation
main.go
Outdated
| } | ||
|
|
||
| flog.Info("starting code-server...") | ||
| localPort := scanAvailablePort() |
There was a problem hiding this comment.
You can just use :0 to make ssh automatically use an available port. This is better than this as with this, a user on macOS will get a prompt asking if they want to let sshcode listen on the network, and then get another prompt for the ssh binary which is confusing.
|
Not bad at all for first time Go btw, most of my issues are just nitpicks. |
kylecarbs
force-pushed
the
core
branch
3 times, most recently
from
83c9b42 to
38698a8
Compare
| `, os.Args[0]) | ||
| } | ||
|
|
||
| flag.Parse() |
There was a problem hiding this comment.
Not a blocker but in the future, you don't need the flag library, you have no flags. You can directly use os.Args.
There was a problem hiding this comment.
Nvm, flag automatically gives you a -h flag which is nice. So this is the way to go.
| `, os.Args[0]) | ||
| } | ||
|
|
||
| flag.Parse() |
There was a problem hiding this comment.
Nvm, flag automatically gives you a -h flag which is nice. So this is the way to go.
| var openCmd *exec.Cmd | ||
| if commandExists("google-chrome") { | ||
| openCmd = exec.Command("google-chrome", "--app="+url, "--disable-extensions", "--disable-plugins") | ||
| } else if commandExists("firefox") { |
There was a problem hiding this comment.
I take it back. If neither of these exist, this program will panic.
| var openCmd *exec.Cmd | ||
| if commandExists("google-chrome") { | ||
| openCmd = exec.Command("google-chrome", "--app="+url, "--disable-extensions", "--disable-plugins") | ||
| } else if commandExists("firefox") { |
2 participants
No description provided.