fix(cli): extend exp scaletest cleanup to properly clean up prebuilds#23628
Open
fix(cli): extend exp scaletest cleanup to properly clean up prebuilds#23628
exp scaletest cleanup to properly clean up prebuilds#23628Conversation
added 2 commits
March 24, 2026 23:05
Prebuild workspaces are owned by the prebuilds system user and not prefixed with scaletest-, so the cleanup command previously left them behind. A new phase runs before the existing workspace/user cleanup, finding templates with the scaletest- prefix and deleting their workspaces before deleting the templates.
…template Instead of looking up workspaces per-template, find all prebuild workspaces directly by owner (the prebuilds system user) and by name substring, merging the results. Workspaces and templates are then deleted in separate phases so templates are only attempted after their workspaces are gone.
|
I have read the CLA Document and I hereby sign the CLA Callum Styan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
github-actions
bot
added
the
community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to the other PRs I've opened today, this PR helps get a scaletest cluster back into a clean state after a prebuild run so that another load generator or another prebuild run is possible. Currently the CLI
exp scaletest cleanupcommand ignores any workspaces/templates created for the prebuilds scaletest.