feat(site): harden Agents embed frame communication and add theme sync#23574
Open
feat(site): harden Agents embed frame communication and add theme sync#23574
Conversation
github-actions
bot
added
the
community
EhabY
changed the title
EhabY
force-pushed
the
fix/agents-embed-frame-communication
branch
from
5b19e4b to
28ed743
Compare
kylecarbs
requested changes
Mar 25, 2026
Comment on lines
+854
to
+857
| // When embedded, scroll to bottom once messages load and | ||
| // notify the parent frame that the chat is ready. Comparing | ||
| // against the last signaled agentId re-fires the notification | ||
| // when the user switches agents without a full remount. |
Member
There was a problem hiding this comment.
Can we do this in the AgentEmbedPage itself rather than here? Conflating them is kinda unfortunate.
Contributor
Author
There was a problem hiding this comment.
Oh right, I've added a callback that we can just listen to in AgentEmbedPage (onChatReady)
Contributor
Author
There was a problem hiding this comment.
So I can remove the whole embedding logic from here but then if I want to scroll to the bottom I'd have to do this:
document.querySelector<HTMLElement>(
'[data-testid="scroll-container"]',
);instead of using refs
Contributor
Author
There was a problem hiding this comment.
Pass a scroll ref instead and seems to work better now!
EhabY
force-pushed
the
fix/agents-embed-frame-communication
branch
from
28ed743 to
477fca0
Compare
Contributor
DanielleMaywood
left a comment
DanielleMaywood
left a comment
There was a problem hiding this comment.
Code review by Pluto 🐕 and team — 3 verified findings (all P3 nits).
No blocking issues. The core implementation is solid: message validation is defensive, effect cleanup is correct for the primary flow, layout/effect timing is well-coordinated, and the useBlocker + postMessage forwarding pattern works cleanly.
🤖 This comment was written by Coder Agent on behalf of Danielle Maywood 🤖
Move the scroll-to-bottom message listener from AgentEmbedPage into AgentDetail so it uses the existing scrollContainerRef instead of a brittle querySelector lookup. Track the last signaled agentId in the chat-ready effect so the notification re-fires when agents change without a full remount. Include location hash in the navigation blocker payload.
Let the parent frame control the embed's color scheme with coder:set-theme messages. On mount the embed applies prefers-color-scheme as an initial value, then listens for explicit theme messages. ThemeProvider skips its own class manipulation when the embed is active, preventing races. Also adds a no-op guard to applyEmbedTheme so duplicate messages skip DOM mutations.
…tDetail Move all embed-specific logic out of AgentDetail into AgentEmbedPage. Chat-ready notification uses the onChatReady outlet context callback. Scroll-to-bottom handling moves to the parent frame message listener in AgentEmbedPage. AgentDetail no longer imports useEmbedContext.
- Remove useCallback from useBlocker (React Compiler handles memoization) - Add classList.remove in theme cleanup to match setup symmetry - Pass scrollContainerRef through outlet context so AgentEmbedPage uses the ref directly instead of querySelector for scroll-to-bottom
EhabY
force-pushed
the
fix/agents-embed-frame-communication
branch
from
580daeb to
66817fa
Compare
Contributor
Documentation CheckNew Documentation Needed
Automated review via Coder Tasks |
DanielleMaywood
approved these changes
Mar 25, 2026
Contributor
DanielleMaywood
left a comment
DanielleMaywood
left a comment
There was a problem hiding this comment.
I'm okay with this but wanna make sure Kyle is
matifali
removed
the
community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentEmbedPageintoAgentDetailso it uses the existingscrollContainerRefinstead of a brittlequerySelectorlookup.coder:chat-readynotification re-fires when the user switches agents without a full remount.coder:navigate.coder:set-thememessage support so the parent frame (e.g. VS Code) can control the embed's color scheme. On mount,themequery is applied immediately to avoid a theme flash; explicit messages override it at any time. ThemeProvider skips its own class manipulation while the embed is active.