Closed
Conversation
coadler
reviewed
Apr 5, 2019
kylecarbs
reviewed
Apr 5, 2019
kirintwn
reviewed
Apr 8, 2019
Contributor
|
LGTM |
sr229
approved these changes
Apr 9, 2019
Contributor
sr229
left a comment
sr229
left a comment
There was a problem hiding this comment.
LGTM, here's a little suggestion for UX reasons
kylecarbs
requested changes
Apr 17, 2019
DAcodedBEAT
approved these changes
Jun 9, 2019
Member
|
Closed in favor of #857. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
If 0.0.0.0 is a bad idea, this sets the default to 127.0.0.1
Is there an open issue you can link to?
#440