Skip to content

Commit e917a81

Browse files
committed
Revert "build: force benchpress to be compiled with ES2020 (angular#49332)" (angular#49554)
This reverts commit 132c00c. PR Close angular#49554
1 parent 132c00c commit e917a81

3 files changed

Lines changed: 3 additions & 10 deletions

File tree

packages/benchpress/BUILD.bazel

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ ts_library(
1010
"src/**/*.ts",
1111
],
1212
),
13-
# TODO(alanagius) fix benchpress to compile with es2022
14-
devmode_target = "es2020",
15-
prodmode_target = "es2020",
1613
deps = [
1714
"//packages:types",
1815
"//packages/core",

packages/benchpress/test/BUILD.bazel

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ ts_library(
44
name = "test_lib",
55
testonly = True,
66
srcs = glob(["**/*.ts"]),
7-
# TODO(alanagius) fix benchpress to compile with es2022
8-
devmode_target = "es2020",
9-
prodmode_target = "es2020",
107
deps = [
118
"//packages:types",
129
"//packages/benchpress",

tools/defaults.bzl

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,6 @@ def ts_library(
103103
deps = [],
104104
module_name = None,
105105
package_name = None,
106-
devmode_target = "es2022",
107-
prodmode_target = "es2022",
108106
**kwargs):
109107
"""Default values for ts_library"""
110108
deps = deps + ["@npm//tslib"]
@@ -124,20 +122,21 @@ def ts_library(
124122
if not package_name:
125123
package_name = _default_module_name(testonly)
126124

125+
default_target = "es2022"
127126
default_module = "esnext"
128127

129128
_ts_library(
130129
name = name,
131130
tsconfig = tsconfig,
132131
testonly = testonly,
133132
deps = deps,
134-
devmode_target = devmode_target,
133+
devmode_target = default_target,
135134
devmode_module = default_module,
136135
# For prodmode, the target is set to `ES2022`. `@bazel/typecript` sets `ES2015` by
137136
# default. Note that this should be in sync with the `ng_module` tsconfig generation.
138137
# https://github.com/bazelbuild/rules_nodejs/blob/901df3868e3ceda177d3ed181205e8456a5592ea/third_party/github.com/bazelbuild/rules_typescript/internal/common/tsconfig.bzl#L195
139138
# https://github.com/bazelbuild/rules_nodejs/blob/9b36274dba34204625579463e3da054a9f42cb47/packages/typescript/internal/build_defs.bzl#L85.
140-
prodmode_target = prodmode_target,
139+
prodmode_target = default_target,
141140
prodmode_module = default_module,
142141
# `module_name` is used for AMD module names within emitted JavaScript files.
143142
module_name = module_name,

0 commit comments

Comments
 (0)