build: fix benchmark sha resolution breaking when compare ref is abbreviated (angular#50767)

devversion · devversion · commit 619c318dcbf5 · 2023-06-19T13:04:02.000Z
When we fetch e.g. `main`, the branch name will not be available locally, and `rev-parse` will fail later. We can make the logic more safe by just using `FETCH_HEAD` then. PR Close angular#50767
diff --git a/scripts/benchmarks/index.mts b/scripts/benchmarks/index.mts
@@ -97,12 +97,10 @@ async function prepareForGitHubAction(commentBody: string): Promise<void> {
   // Attempt to find the compare SHA. The commit may be either part of the
   // pull request, or might be a commit unrelated to the PR- but part of the
   // upstream repository. We attempt to fetch/resolve the SHA in both remotes.
-  let compareRefSha: string|null = null;
-  try {
-    compareRefSha = git.run(['rev-parse', compareRefRaw]).stdout.trim();
-  } catch {
+  let compareRefSha = git.runGraceful(['rev-parse', compareRefRaw]).stdout.trim();
+  if (compareRefSha === '') {
     git.run(['fetch', '--depth=1', git.getRepoGitUrl(), compareRefRaw]);
-    compareRefSha = git.run(['rev-parse', compareRefRaw]).stdout.trim();
+    compareRefSha = git.run(['rev-parse', 'FETCH_HEAD']).stdout.trim();
   }
 
   setOutput('compareSha', compareRefSha);
