Skip to content

Fixes #5003: suppress toast on error #5044

Open
ulischulte wants to merge 7 commits intomasterfrom
fix/5003-suppress-toasts-on-missing-metric
Open

Fixes #5003: suppress toast on error #5044
ulischulte wants to merge 7 commits intomasterfrom
fix/5003-suppress-toasts-on-missing-metric

Conversation

@ulischulte
Copy link
Contributor

@ulischulte ulischulte commented Feb 6, 2026 •
edited
Loading

Fixes #5003: suppress toast on error via option to axios request config (boolean or function)

@ulischulte ulischulte requested a review from a team as a code owner February 6, 2026 16:51
@ulischulte ulischulte marked this pull request as draft February 6, 2026 16:54
@SteKoe
Copy link
Contributor

SteKoe commented Feb 10, 2026

Hey @ulischulte,

this will suppress errors in any case, right? So even if cache.gets is available but throws, for some reason, a 400 (or similar), no toast will be shown, right? Wouldn't it be better to check, if cache.gets is available at all, and if, show error toasts, if not, suppress them or even just don't execute the call?

@ulischulte
Copy link
Contributor Author

ulischulte commented Feb 11, 2026

Hey @ulischulte,

this will suppress errors in any case, right? So even if cache.gets is available but throws, for some reason, a 400 (or similar), no toast will be shown, right? Wouldn't it be better to check, if cache.gets is available at all, and if, show error toasts, if not, suppress them or even just don't execute the call?

Sorry, implementation wasn't finished yet. Right now, it should only suppress 404 statusCodes on cache.size requests.

@SteKoe
Copy link
Contributor

SteKoe commented Feb 12, 2026 •
edited
Loading

I will wait for this PR to become reviewable/not a draft. :) sorry!

@ulischulte ulischulte marked this pull request as ready for review February 13, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error toast, when redis cache is used stating 404 on cache.size.

2 participants

@ulischulte @SteKoe