Skip to content

Commit 5e98d60

Browse files
tkrusetheandrewdavis
authored andcommitted
Adapt regression tests to new rules about lambda and global string vars
1 parent 54b6261 commit 5e98d60

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

samples/codelite-sample/simple.def

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,7 @@ src/pptable.cpp:576: Tab found; better to use spaces [whitespace/tab] [1]
526526
src/pptable.cpp:577: Tab found; better to use spaces [whitespace/tab] [1]
527527
src/pptable.cpp:578: Tab found; better to use spaces [whitespace/tab] [1]
528528
src/pptable.cpp:579: Tab found; better to use spaces [whitespace/tab] [1]
529+
src/pptable.cpp:582: Static/global string variables are not permitted. [runtime/string] [4]
529530
src/pptable.cpp:584: Lines should be <= 80 characters long [whitespace/line_length] [2]
530531
src/pptable.cpp:584: Is this a non-const reference? If so, make const or use a pointer: std::string& outStr [runtime/references] [2]
531532
src/pptable.cpp:585: { should almost always be at the end of the previous line [whitespace/braces] [4]

samples/silly-sample/simple.def

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,9 @@ src/sillycode.cpp:166: Do not use variable-length arrays. Use an appropriately
6262
src/sillycode.cpp:170: Tab found; better to use spaces [whitespace/tab] [1]
6363
src/sillycode.cpp:173: Tab found; better to use spaces [whitespace/tab] [1]
6464
src/sillycode.cpp:173: At least two spaces is best between code and comments [whitespace/comments] [2]
65-
src/sillycode.cpp:173: For a static/global string constant, use a C style string instead: "char s[]". [runtime/string] [4]
65+
src/sillycode.cpp:173: Static/global string variables are not permitted. [runtime/string] [4]
6666
src/sillycode.cpp:174: Tab found; better to use spaces [whitespace/tab] [1]
6767
src/sillycode.cpp:174: At least two spaces is best between code and comments [whitespace/comments] [2]
68-
src/sillycode.cpp:178: Default lambda captures are an unapproved C++ feature. [build/c++11] [4]
6968
src/sillycode.cpp:179: Tab found; better to use spaces [whitespace/tab] [1]
7069
src/sillycode.cpp:179: At least two spaces is best between code and comments [whitespace/comments] [2]
7170
src/sillycode.cpp:185: Tab found; better to use spaces [whitespace/tab] [1]
@@ -78,8 +77,7 @@ src/sillycode.cpp:194: If an else has a brace on one side, it should have it on
7877
src/sillycode.cpp:197: An else should appear on the same line as the preceding } [whitespace/newline] [4]
7978
src/sillycode.cpp:197: If an else has a brace on one side, it should have it on both [readability/braces] [5]
8079
src/sillycode.cpp:203: Missing space before { [whitespace/braces] [5]
81-
src/sillycode.cpp:203: For a static/global string constant, use a C style string instead: "char var[]". [runtime/string] [4]
82-
src/sillycode.cpp:203: Default lambda captures are an unapproved C++ feature. [build/c++11] [4]
80+
src/sillycode.cpp:203: Static/global string variables are not permitted. [runtime/string] [4]
8381
src/sillycode.cpp:204: Tab found; better to use spaces [whitespace/tab] [1]
8482
src/sillycode.cpp:204: At least two spaces is best between code and comments [whitespace/comments] [2]
8583
src/sillycode.cpp:209: At least two spaces is best between code and comments [whitespace/comments] [2]
@@ -92,6 +90,7 @@ src/sillycode.cpp:215: Tab found; better to use spaces [whitespace/tab] [1]
9290
src/sillycode.cpp:215: At least two spaces is best between code and comments [whitespace/comments] [2]
9391
src/sillycode.cpp:220: Tab found; better to use spaces [whitespace/tab] [1]
9492
src/sillycode.cpp:220: At least two spaces is best between code and comments [whitespace/comments] [2]
93+
src/sillycode.cpp:222: Static/global string variables are not permitted. [runtime/string] [4]
9594
src/sillycode.cpp:223: At least two spaces is best between code and comments [whitespace/comments] [2]
9695
src/sillycode.cpp:223: Using C-style cast. Use reinterpret_cast<double*>(...) instead [readability/casting] [4]
9796
src/sillycode.cpp:231: public: should be indented +1 space inside class derived2 [whitespace/indent] [3]

0 commit comments

Comments
 (0)