Conversation
Split name into first and last, rewrite model and API specs
Fix issue with Sinatra rack temporarily
Rails upgrade from 4.2.5.1 to 5.0.0
Update vagrant configuration Update AMS renderer Fix specs for json api content type Update Vagrantfile to account for ports < 1024 Fix for nil case in specs Add elasticsearch Fix import specs Update docs
Add ansible
…ting through migration
Create #add_url_protocol method for before_save on users, update exis…
Add SMTP settings
Update docker and README Add ruby version Update README Update bundler until bugs are fixed Clean up Dockerfile and remove Ansible Remove Ansible shell scripts Update setup scripts and dockerfile again Update bin and colors Update docs
Add docker
Improve docs for install/usage
Add first and last name to analytics tracking Add adapter and remove scenario Change location of adapter and write spec for mailing list Add worker and spec Add controller specs for signing up Add rake task
Subscribe users to mailchimp on signup
| serialization = | ||
| ActiveModel::Serializer::Adapter.create(serializer, include: includes, meta: meta) | ||
| ActiveModelSerializers::Adapter.create( | ||
| serializer, |
There was a problem hiding this comment.
Indent the first parameter one step more than the start of the previous line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.