roachtest: set pgwire max repeated error to 256 in c2c mixed version #160273
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On pre 26.1 versions by default, pgwire retries opening a connection tens of thousands of times, which could cause overload in the c2c/mixedversion roachtest. Now that `sql.pgwire.max_repeated_error_count` has been backported to 25.2+, we can deflake the roachtest by setting the max error count to 256. Informs cockroachdb#150401 Release note: none
Member
|
This change is |
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
github-actions
bot
added
the
o-AI-Review-Potential-Issue-Detected
msbutler
added
the
O-AI-Review-Not-Helpful
kev-cao
approved these changes
Dec 29, 2025
Collaborator
Author
|
TFTR! bors r=kev-cao |
msbutler
added
backport-25.4.x
Contributor
|
Build succeeded: |
This was referenced Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On pre 26.1 versions by default, pgwire retries opening a connection tens of thousands of times, which could cause overload in the c2c/mixedversion roachtest. Now that
sql.pgwire.max_repeated_error_counthas been backported to 25.2+, we can deflake the roachtest by setting the max error count to 256.Informs #150401
Release note: none