feat: Add table option to filter workflow runs#17539
Merged
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom Apr 8, 2024
Merged
feat: Add table option to filter workflow runs#17539kodiakhq[bot] merged 6 commits intocloudquery:mainfrom
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom
Conversation
erezrokah
requested review from
a team and
candiduslynx
and removed request for
a team
candiduslynx
reviewed
Apr 8, 2024
Member
Author
|
Ok forgot to add docs, doing it now |
candiduslynx
approved these changes
Apr 8, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
🤖 I have created a release *beep* *boop* --- ## [9.2.0](plugins-source-github-v9.1.0...plugins-source-github-v9.2.0) (2024-04-08) ### Features * Add table option to filter workflow runs ([#17539](#17539)) ([202fe42](202fe42)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.36.4 ([#17485](#17485)) ([f370de4](f370de4)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.36.5 ([#17526](#17526)) ([554c499](554c499)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.37.0 ([#17532](#17532)) ([8080970](8080970)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tried to do #17475 using
created_atcolumn but that's not really possible as while we can filter based on acreated_atrange the results are always returned in descending order, so we always get newest results first.Which means that if the sync stops in the middle and we only get part of the data, next sync we'd have to split the range to get the runs before the oldest we retrieved and after the newest (and do a split each time we have partial state).
We could maybe save the state only after retrieving all the pages (and not after each page) which should ensure we don't have data to catch up on in the next sync.
This PR does something else, it adds a table option to let users specify the range they'd like to sync.
Opening for feedback