feat: Add validate-config command#17530
Merged
kodiakhq[bot] merged 18 commits intomainfrom Apr 5, 2024
Merged
Conversation
erezrokah
reviewed
Apr 5, 2024
1 task
bbernays
requested review from
a team and
candiduslynx
and removed request for
a team
erezrokah
reviewed
Apr 5, 2024
erezrokah
reviewed
Apr 5, 2024
erezrokah
approved these changes
Apr 5, 2024
disq
reviewed
Apr 5, 2024
disq
reviewed
Apr 5, 2024
erezrokah
reviewed
Apr 5, 2024
erezrokah
reviewed
Apr 5, 2024
| name: aws | ||
| path: cloudquery/aws | ||
| registry: cloudquery | ||
| version: "v25.5.0" |
Member
There was a problem hiding this comment.
Our CLI tests are unauthenticated so using this version might not work
Collaborator
Author
There was a problem hiding this comment.
I am seeing other weird issues as well even locally
Member
There was a problem hiding this comment.
38c85d8 should fix it and uses cloudflare as it's faster to download
Member
|
I would also point us that this won't validate the |
Collaborator
Author
Added that caveat to the description |
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
🤖 I have created a release *beep* *boop* --- ## [5.14.0](cli-v5.13.1...cli-v5.14.0) (2024-04-05) ### Features * Add `validate-config` command ([#17530](#17530)) ([959c5f7](959c5f7)) * Expose `test-connection` command in docs ([#17308](#17308)) ([709a4c9](709a4c9)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.19.8 ([#17482](#17482)) ([b37d109](b37d109)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.36.4 ([#17485](#17485)) ([f370de4](f370de4)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.36.5 ([#17526](#17526)) ([554c499](554c499)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.37.0 ([#17532](#17532)) ([8080970](8080970)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a strict
validate-configcommand that ensures that all specified configs match with the plugin JSON Spec. This validation is more strict than what we require during asyncbut if a config passes this validation it will pass the validation at sync time