feat!: Skip archived repositories by default, rename skip_archived_repos to include_archived_repos#17339
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Mar 27, 2024
Conversation
erezrokah
requested review from
a team and
bbernays
and removed request for
a team
bbernays
approved these changes
Mar 26, 2024
erezrokah
added
no automerge
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
🤖 I have created a release *beep* *boop* --- ## [9.0.0](plugins-source-github-v8.2.1...plugins-source-github-v9.0.0) (2024-04-02) ### ⚠ BREAKING CHANGES * Change default concurrency to 1500 instead of 10000 to better align with GitHub rate limits ([#17369](#17369)) * Skip archived repositories by default, rename `skip_archived_repos` to `include_archived_repos` ([#17339](#17339)) ### Features * Skip archived repositories by default, rename `skip_archived_repos` to `include_archived_repos` ([#17339](#17339)) ([b1ab433](b1ab433)) ### Bug Fixes * Change default concurrency to 1500 instead of 10000 to better align with GitHub rate limits ([#17369](#17369)) ([b757cf7](b757cf7)) * **deps:** Update module github.com/cloudquery/codegen to v0.3.13 ([#17444](#17444)) ([da276fe](da276fe)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.36.1 ([#17372](#17372)) ([aaf6187](aaf6187)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.36.2 ([#17450](#17450)) ([2947506](2947506)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.36.3 ([#17456](#17456)) ([020865a](020865a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on https://github.com/orgs/community/discussions/8591 this seems like a better default.
Follow up to #15593 and related to #17041
Also related to #17309
Still need to test the impact on rate limits