Skip to content

feat: Add local sync summary#17112

Merged
kodiakhq[bot] merged 42 commits intomainfrom
sync-summary
Apr 2, 2024
Merged

feat: Add local sync summary#17112
kodiakhq[bot] merged 42 commits intomainfrom
sync-summary

Conversation

@bbernays
Copy link
Copy Markdown
Collaborator

@bbernays bbernays commented Mar 11, 2024

Summary

This pr adds in a sync summary that gets outputted to a user defined location. If the user doesn't define the location via the cli flag then the summary will not be persisted.

The file is a .jsonl format

Copy link
Copy Markdown
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I believe this closes #8690

@bbernays bbernays linked an issue Mar 11, 2024 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's schedule another meeting on that to discuss the use case

@bbernays bbernays requested a review from hermanschaaf March 25, 2024 17:23
@bbernays bbernays dismissed yevgenypats’s stale review March 25, 2024 17:44

Made summary local to CLI

@bbernays bbernays linked an issue Mar 26, 2024 that may be closed by this pull request
@bbernays bbernays added the no automerge Block automatic merging label Mar 26, 2024
Comment thread cli/cmd/sync_test.go
Comment thread cli/cmd/migrate_v3.go Outdated
Copy link
Copy Markdown
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, had a few questions/comments

Comment thread cli/cmd/summary.go Outdated
Comment thread cli/cmd/sync.go Outdated
Comment thread cli/cmd/summary.go
Comment thread cli/cmd/sync_v3.go
@bbernays bbernays added automerge Automatically merge once required checks pass priority merge and removed no automerge Block automatic merging labels Apr 2, 2024
@kodiakhq kodiakhq bot merged commit d98f544 into main Apr 2, 2024
@kodiakhq kodiakhq bot deleted the sync-summary branch April 2, 2024 18:24
kodiakhq bot pushed a commit that referenced this pull request Apr 2, 2024
🤖 I have created a release *beep* *boop*
---


## [5.13.0](cli-v5.12.1...cli-v5.13.0) (2024-04-02)


### Features

* Add local sync summary ([#17112](#17112)) ([d98f544](d98f544))


### Bug Fixes

* **deps:** Update golang.org/x/exp digest to a685a6e ([#17429](#17429)) ([093bc86](093bc86))
* **deps:** Update module github.com/cloudquery/codegen to v0.3.13 ([#17444](#17444)) ([da276fe](da276fe))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.19.6 ([#17446](#17446)) ([cd73a0a](cd73a0a))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.19.7 ([#17447](#17447)) ([48665fb](48665fb))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.36.2 ([#17450](#17450)) ([2947506](2947506))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.36.3 ([#17456](#17456)) ([020865a](020865a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli area/website automerge Automatically merge once required checks pass priority merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Store Sync Summary

5 participants